Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/WP-725: Mutation Hooks: Extract Files #1010

Closed
wants to merge 12 commits into from
Closed

Conversation

jmcmillenmusic
Copy link
Collaborator

Overview

We are working on updating our current mutations to utilize TypeScript and React Query instead of React Redux. This should improve the speed and functionality of all portal systems going forward.

Related

Changes

I converted useExtract.js to useExtract.ts and created a mutation that extracts files from a ZIP file into the directory where the ZIP file is currently located.

Testing

  1. Navigate to a ZIP file in any directory.
  2. Select that ZIP file and click on the Extract button.
  3. In the modal that appears, click on the purple Extract button.
  4. A job gets submitted to extract files from the ZIP file, and you'll eventually see the folder containing those files in that directory.

UI

image

Notes

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.83%. Comparing base (498d801) to head (d63cda4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/portal/apps/workspace/api/views.py 40.00% 2 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (498d801) and HEAD (d63cda4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (498d801) HEAD (d63cda4)
javascript 1 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1010       +/-   ##
===========================================
- Coverage   72.68%   60.83%   -11.86%     
===========================================
  Files         534      211      -323     
  Lines       33657     6288    -27369     
  Branches     2989      731     -2258     
===========================================
- Hits        24464     3825    -20639     
+ Misses       8995     2302     -6693     
+ Partials      198      161       -37     
Flag Coverage Δ
javascript ?
unittests 60.83% <40.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
server/portal/settings/settings_default.py 0.00% <ø> (ø)
server/portal/apps/workspace/api/views.py 55.83% <40.00%> (-0.25%) ⬇️

... and 322 files with indirect coverage changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's build this branch off of task/WP-724, to pick up the base changes there

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and done! This PR will be closed to accommodate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants